Skip to content

feat(linux-workspace): name a tab's database in its title when not the connection's own - #3904

Merged
datlechin merged 137 commits into
TableProApp:mainfrom
sedax90:feat/linux-editor-tab-title-database
Oct 31, 2026
Merged

datlechin merged 137 commits into
TableProApp:mainfrom
sedax90:feat/linux-editor-tab-title-database

Conversation

@sedax90

@sedax90 sedax90 commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Follows #3897. Rebuilt on main without #3902 and #3903: a moved tab names its database in its title, nothing else.

Summary

  • A query tab names its database after its title when it is not the connection's own: "Query 1 (analytics)", or "Query 1 (prod, analytics)" while another connection shares the tab bar.
  • The tooltip names it on a line of its own.
  • The title follows the tab when it moves, from the bar or with a USE, and drops the name when it returns to the connection's database.
  • A tab already in the database the server later lists as the connection's own drops the name, and its record forgets the move.

Screenshots

The tab strip, MySQL, Query 1 moved to analytics.

Light Dark
Before Before, light Before, dark
After After, light After, dark

Test plan

  • workspace::tests::tab_title::a_tab_moved_to_another_database_names_it fails on main.
  • editor::tests::a_tab_in_the_database_the_server_then_calls_its_own_is_not_moved.
  • tab_title::tests::a_tab_names_its_database_and_the_connection_it_shares_the_bar_with.
  • CI builds and runs the suites; no local Linux runner was available for this round.

sedax90 and others added 24 commits October 30, 2026 09:37
…or-database-switch

# Conflicts:
#	linux/crates/app/src/ui/editor/tab_scope.rs
#	linux/data/resources/ui/sql-editor.ui
…or-database-switch-more

# Conflicts:
#	linux/crates/app/src/ui/editor/editor_session_slot.rs
#	linux/crates/core/src/dialect/sql_dialect.rs
#	linux/crates/drivers/mongodb/src/dialect.rs
…-editor-database-switch-reconnect

# Conflicts:
#	linux/crates/app/src/ui/editor/editor_session_slot.rs
#	linux/crates/core/src/dialect/sql_dialect.rs
#	linux/crates/drivers/mongodb/src/dialect.rs
#	linux/crates/drivers/postgres/src/dialect.rs
…nux-editor-follows-database-session

# Conflicts:
#	linux/crates/app/src/ui/editor/tab_scope.rs
@datlechin
datlechin merged commit ab0578d into TableProApp:main Oct 31, 2026
38 of 40 checks passed
datlechin added a commit to sedax90/TablePro that referenced this pull request Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants